Paths

Table of Contentst

Fix fatal when searching for "r matey prepare to be boarded"
ClosedPublic
Actions

Authored by epriestley on Sep 29 2017, 4:02 PM.

Tags

None

Referenced Files

	F19239245: D18661.diff
	Dec 21 2025, 8:44 PM

	F18988687: D18661.diff
	Nov 18 2025, 6:48 AM

	F18902116: D18661.id44806.diff
	Nov 7 2025, 11:54 PM

	F18809694: D18661.diff
	Oct 19 2025, 4:14 PM

	F18787419: D18661.diff
	Oct 14 2025, 11:39 PM

	F18613552: D18661.id.diff
	Sep 14 2025, 11:18 AM

	F18199827: D18661.id44806.diff
	Aug 18 2025, 2:24 AM

	F18160288: D18661.id44805.diff
	Aug 15 2025, 1:48 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa3a6c4ed2edf: Fix fatal when searching for "r matey prepare to be boarded"

Summary

See https://discourse.phabricator-community.org/t/unrecoverable-fatal-error-on-repository-search-in-top-search-bar/503/2.

The Ferret engine replaced withNameContains(), but I missed this obscure callsite.

Test Plan

Searched for r matey prepare to be boarded.
Before: fatal.
After: no fatal.
Also searched for r <actual repository name>, got repository.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 29 2017, 4:02 PM

Harbormaster completed remote builds in B18585: Diff 44805.Sep 29 2017, 4:03 PM

yarrrr

This revision is now accepted and ready to land.Sep 29 2017, 4:41 PM

Closed by commit rPa3a6c4ed2edf: Fix fatal when searching for "r matey prepare to be boarded" (authored by epriestley). · Explain WhySep 29 2017, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorJumpNavHandler.php

24 lines

Diff 44806

View Options

src/applications/search/engine/PhabricatorJumpNavHandler.php

Fix fatal when searching for "r matey prepare to be boarded"ClosedPublicActions