Paths

Table of Contentst

Fix fatal when searching for "r matey prepare to be boarded"
ClosedPublic
Actions

Authored by epriestley on Sep 29 2017, 4:02 PM.

Tags

None

Referenced Files

	F18199827: D18661.id44806.diff
	Mon, Aug 18, 2:24 AM

	F18160288: D18661.id44805.diff
	Fri, Aug 15, 1:48 AM

	F18123355: D18661.id.diff
	Aug 13 2025, 12:17 PM

	F18113303: D18661.diff
	Aug 13 2025, 1:15 AM

	F17700829: D18661.diff
	Jul 15 2025, 9:07 PM

	Unknown Object (File)
	Jun 2 2025, 5:48 AM

	Unknown Object (File)
	Apr 26 2025, 11:15 AM

	Unknown Object (File)
	Apr 25 2025, 10:56 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa3a6c4ed2edf: Fix fatal when searching for "r matey prepare to be boarded"

Summary

See https://discourse.phabricator-community.org/t/unrecoverable-fatal-error-on-repository-search-in-top-search-bar/503/2.

The Ferret engine replaced withNameContains(), but I missed this obscure callsite.

Test Plan

Searched for r matey prepare to be boarded.
Before: fatal.
After: no fatal.
Also searched for r <actual repository name>, got repository.

Diff Detail

Repository

rP Phabricator

Branch

jump1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18585
Build 25033: Run Core Tests
Build 25032: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 29 2017, 4:02 PM

Harbormaster completed remote builds in B18585: Diff 44805.Sep 29 2017, 4:03 PM

yarrrr

This revision is now accepted and ready to land.Sep 29 2017, 4:41 PM

Closed by commit rPa3a6c4ed2edf: Fix fatal when searching for "r matey prepare to be boarded" (authored by epriestley). · Explain WhySep 29 2017, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorJumpNavHandler.php

24 lines

Diff 44805

View Options

src/applications/search/engine/PhabricatorJumpNavHandler.php

Fix fatal when searching for "r matey prepare to be boarded"ClosedPublicActions