Page MenuHomePhabricator
Differential D18629

Fix an error in Diffusion when the Owners application is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 19 2017, 4:23 PM.
Tags
None
Referenced Files
F14845213: D18629.diff
Sun, Feb 2, 9:23 PM
Unknown Object (File)
Sat, Feb 1, 7:49 AM
Unknown Object (File)
Sun, Jan 26, 10:57 PM
Unknown Object (File)
Fri, Jan 24, 10:36 PM
Unknown Object (File)
Fri, Jan 24, 12:51 AM
Unknown Object (File)
Tue, Jan 21, 10:42 AM
Unknown Object (File)
Thu, Jan 16, 9:04 AM
Unknown Object (File)
Fri, Jan 10, 11:18 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP52fff638ca9b: (stable) Fix an error in Diffusion when the Owners application is uninstalled
rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled
Summary

See https://discourse.phabricator-community.org/t/undefined-view-when-owners-is-uninstalled/451.

When Owners is not installed, Diffusion can fatal with a bad $view.

Test Plan
  • Uninstall Owners.
  • View the content of any file in Diffusion.
  • Before: fatal on $view undefined.
  • After: Valid page with no owners information.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
120 lines

Diff 44725

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility