Fix an error in Diffusion when the Owners application is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 19 2017, 4:23 PM.

Details

Reviewers

Commits

rP52fff638ca9b: (stable) Fix an error in Diffusion when the Owners application is uninstalled
rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled

Summary

See https://discourse.phabricator-community.org/t/undefined-view-when-owners-is-uninstalled/451.

When Owners is not installed, Diffusion can fatal with a bad $view.

Test Plan

Uninstall Owners.
View the content of any file in Diffusion.
Before: fatal on $view undefined.
After: Valid page with no owners information.

Diff Detail

Repository

rP Phabricator

Branch

owners1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18500
Build 24915: Run Core Tests
Build 24914: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 19 2017, 4:23 PM

Harbormaster completed remote builds in B18500: Diff 44724.Sep 19 2017, 4:24 PM

amckinley accepted this revision.Sep 19 2017, 4:40 PM

This revision is now accepted and ready to land.Sep 19 2017, 4:40 PM

Closed by commit rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled (authored by epriestley). · Explain WhySep 19 2017, 4:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

120 lines

Diff 44724

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Fix an error in Diffusion when the Owners application is uninstalledClosedPublicActions