Page MenuHomePhabricator
Differential D18629

Fix an error in Diffusion when the Owners application is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 19 2017, 4:23 PM.
Tags
None
Referenced Files
F15502340: D18629.id44725.diff
Sun, Apr 13, 11:56 PM
F15494398: D18629.id44724.diff
Sat, Apr 12, 11:38 PM
F15487114: D18629.id.diff
Thu, Apr 10, 11:20 AM
F15485493: D18629.diff
Thu, Apr 10, 12:08 AM
F15406624: D18629.id44724.diff
Mar 18 2025, 12:56 PM
F15398779: D18629.id44725.diff
Mar 17 2025, 1:37 AM
F15369354: D18629.diff
Mar 12 2025, 6:22 AM
F15302820: D18629.diff
Mar 5 2025, 10:24 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP52fff638ca9b: (stable) Fix an error in Diffusion when the Owners application is uninstalled
rP03e5d69817c9: Fix an error in Diffusion when the Owners application is uninstalled
Summary

See https://discourse.phabricator-community.org/t/undefined-view-when-owners-is-uninstalled/451.

When Owners is not installed, Diffusion can fatal with a bad $view.

Test Plan
  • Uninstall Owners.
  • View the content of any file in Diffusion.
  • Before: fatal on $view undefined.
  • After: Valid page with no owners information.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18500
Build 24915: Run Core Tests
Build 24914: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
120 lines

Diff 44724

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility