Page MenuHomePhabricator
Files F14845213

D18629.diff
No OneTemporary
Actions

D18629.diff
View Options

diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php
--- a/src/applications/diffusion/controller/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseController.php
@@ -799,75 +799,79 @@
}
private function buildOwnersList(DiffusionRequest $drequest) {
-
$viewer = $this->getViewer();
- $repository = $drequest->getRepository();
- $owners = 'PhabricatorOwnersApplication';
- if (PhabricatorApplication::isClassInstalled($owners)) {
- $package_query = id(new PhabricatorOwnersPackageQuery())
- ->setViewer($viewer)
- ->withStatuses(array(PhabricatorOwnersPackage::STATUS_ACTIVE))
- ->withControl(
- $repository->getPHID(),
- array(
- $drequest->getPath(),
- ));
+ $have_owners = PhabricatorApplication::isClassInstalledForViewer(
+ 'PhabricatorOwnersApplication',
+ $viewer);
+ if (!$have_owners) {
+ return null;
+ }
- $package_query->execute();
+ $repository = $drequest->getRepository();
- $packages = $package_query->getControllingPackagesForPath(
+ $package_query = id(new PhabricatorOwnersPackageQuery())
+ ->setViewer($viewer)
+ ->withStatuses(array(PhabricatorOwnersPackage::STATUS_ACTIVE))
+ ->withControl(
$repository->getPHID(),
- $drequest->getPath());
-
- $ownership = id(new PHUIObjectItemListView())
- ->setUser($viewer)
- ->setNoDataString(pht('No Owners'));
-
- if ($packages) {
- foreach ($packages as $package) {
- $item = id(new PHUIObjectItemView())
- ->setObject($package)
- ->setObjectName($package->getMonogram())
- ->setHeader($package->getName())
- ->setHref($package->getURI());
-
- $owners = $package->getOwners();
- if ($owners) {
- $owner_list = $viewer->renderHandleList(
- mpull($owners, 'getUserPHID'));
- } else {
- $owner_list = phutil_tag('em', array(), pht('None'));
- }
- $item->addAttribute(pht('Owners: %s', $owner_list));
-
- $auto = $package->getAutoReview();
- $autoreview_map = PhabricatorOwnersPackage::getAutoreviewOptionsMap();
- $spec = idx($autoreview_map, $auto, array());
- $name = idx($spec, 'name', $auto);
- $item->addIcon('fa-code', $name);
-
- if ($package->getAuditingEnabled()) {
- $item->addIcon('fa-check', pht('Auditing Enabled'));
- } else {
- $item->addIcon('fa-ban', pht('No Auditing'));
- }
+ array(
+ $drequest->getPath(),
+ ));
- if ($package->isArchived()) {
- $item->setDisabled(true);
- }
+ $package_query->execute();
+
+ $packages = $package_query->getControllingPackagesForPath(
+ $repository->getPHID(),
+ $drequest->getPath());
- $ownership->addItem($item);
+ $ownership = id(new PHUIObjectItemListView())
+ ->setUser($viewer)
+ ->setNoDataString(pht('No Owners'));
+
+ if ($packages) {
+ foreach ($packages as $package) {
+ $item = id(new PHUIObjectItemView())
+ ->setObject($package)
+ ->setObjectName($package->getMonogram())
+ ->setHeader($package->getName())
+ ->setHref($package->getURI());
+
+ $owners = $package->getOwners();
+ if ($owners) {
+ $owner_list = $viewer->renderHandleList(
+ mpull($owners, 'getUserPHID'));
+ } else {
+ $owner_list = phutil_tag('em', array(), pht('None'));
}
- }
+ $item->addAttribute(pht('Owners: %s', $owner_list));
- $view = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Owner Packages'))
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
- ->addClass('diffusion-mobile-view')
- ->setObjectList($ownership);
+ $auto = $package->getAutoReview();
+ $autoreview_map = PhabricatorOwnersPackage::getAutoreviewOptionsMap();
+ $spec = idx($autoreview_map, $auto, array());
+ $name = idx($spec, 'name', $auto);
+ $item->addIcon('fa-code', $name);
+
+ if ($package->getAuditingEnabled()) {
+ $item->addIcon('fa-check', pht('Auditing Enabled'));
+ } else {
+ $item->addIcon('fa-ban', pht('No Auditing'));
+ }
+
+ if ($package->isArchived()) {
+ $item->setDisabled(true);
+ }
+
+ $ownership->addItem($item);
+ }
}
+ $view = id(new PHUIObjectBoxView())
+ ->setHeaderText(pht('Owner Packages'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->addClass('diffusion-mobile-view')
+ ->setObjectList($ownership);
+
return $view;
}

File Metadata

Mime Type
text/plain
Expires
Mon, Feb 3, 9:23 PM (21 h, 32 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7087856
Default Alt Text
D18629.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility