Fix an outdated HTML anchor link in Diffusion table of contents
ClosedPublic
Actions

Authored by epriestley on Sep 15 2017, 12:34 PM.

Details

Reviewers

amckinley

Commits

rP5ae3af6691ca: Fix an outdated HTML anchor link in Diffusion table of contents

Summary

See https://discourse.phabricator-community.org/t/navigating-to-changed-files-in-diffusion-does-not-work-anymore/433.

In D18465, I updated these but this hard-coded the anchor for some reason (???) and I missed it while grep-ing.

Test Plan

Viewed a commit (/rXYZaaaa) and clicked a file link in the table of contents. Got modern #change-... anchor and navigation into the document.

Diff Detail

Repository

rP Phabricator

Branch

anchor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18459
Build 24856: Run Core Tests
Build 24855: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 15 2017, 12:34 PM

Harbormaster completed remote builds in B18459: Diff 44679.Sep 15 2017, 12:34 PM

Harbormaster completed remote builds in B18459: Diff 44679.

amckinley accepted this revision.Sep 15 2017, 3:34 PM

This revision is now accepted and ready to land.Sep 15 2017, 3:34 PM

Closed by commit rP5ae3af6691ca: Fix an outdated HTML anchor link in Diffusion table of contents (authored by epriestley). · Explain WhySep 15 2017, 3:37 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13045: Differential file anchors may contain characters which prevent remarkup linking properly.Jan 22 2018, 4:27 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionCommitController.php

2 lines

Diff 44679

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Fix an outdated HTML anchor link in Diffusion table of contentsClosedPublicActions