Page MenuHomePhabricator
Differential D18541

Fix a similar lint rendering issue when trimming identical lines out of patches
ClosedPublic
Actions

Authored by epriestley on Sep 5 2017, 11:53 PM.
Tags
None
Referenced Files
F13237956: D18541.id44525.diff
Tue, May 21, 4:11 PM
F13233811: D18541.diff
Tue, May 21, 2:35 AM
F13215129: D18541.id44524.diff
Fri, May 17, 3:12 PM
F13215101: D18541.id44523.diff
Fri, May 17, 3:00 PM
F13213822: D18541.diff
Fri, May 17, 8:06 AM
Unknown Object (File)
Tue, May 7, 8:26 AM
Unknown Object (File)
Fri, May 3, 8:15 AM
Unknown Object (File)
Tue, Apr 30, 12:08 PM
View All Files
Subscribers
alexmv

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC92f7b2986cd7: (stable) Promote 2017 Week 36
rARCcbc785ddce71: Fix a similar lint rendering issue when trimming identical lines out of patches
Summary

Ref T9846. See PHI48. See D18538 for a similar fix. We can contract the suffix lines too much if, e.g, a newline after another newline is removed. Prevent contraction to fewer than 0 lines.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rARC Arcanist
Branch
remline
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18306
Build 24634: Run Core Tests
Build 24633: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
10 lines
__tests__/
24 lines
data/
12 lines
6 lines

Diff 44523

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/remline.expect

Loading...
View Options

src/lint/renderer/__tests__/data/remline.txt

Loading...
Phabricator · Built by Phacility