Fix a similar lint rendering issue when trimming identical lines out of patches
ClosedPublic
Actions

Authored by epriestley on Sep 5 2017, 11:53 PM.

Details

Reviewers

Maniphest Tasks

T9846: Diff on `arc lint` misleading when the replacement has newlines

Commits

rARC92f7b2986cd7: (stable) Promote 2017 Week 36
rARCcbc785ddce71: Fix a similar lint rendering issue when trimming identical lines out of patches

Summary

Ref T9846. See PHI48. See D18538 for a similar fix. We can contract the suffix lines too much if, e.g, a newline after another newline is removed. Prevent contraction to fewer than 0 lines.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository

rARC Arcanist

Branch

remline

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18307
Build 24636: Run Core Tests
Build 24635: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 5 2017, 11:53 PM

Harbormaster completed remote builds in B18306: Diff 44523.Sep 5 2017, 11:54 PM

Slightly more precise comment.

Harbormaster completed remote builds in B18307: Diff 44524.Sep 5 2017, 11:55 PM

alexmv added a subscriber: alexmv.Sep 5 2017, 11:58 PM

chad accepted this revision.Sep 6 2017, 12:11 AM

This revision is now accepted and ready to land.Sep 6 2017, 12:11 AM

Closed by commit rARCcbc785ddce71: Fix a similar lint rendering issue when trimming identical lines out of patches (authored by epriestley). · Explain WhySep 6 2017, 12:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

renderer/

ArcanistConsoleLintRenderer.php

11 lines

__tests__/

ArcanistConsoleLintRendererTestCase.php

24 lines

data/

remline.expect

12 lines

remline.txt

6 lines

Diff 44524

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

View Options

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

View Options

src/lint/renderer/tests/data/remline.expect

View Options

src/lint/renderer/tests/data/remline.txt

Fix a similar lint rendering issue when trimming identical lines out of patchesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44524

src/lint/renderer/ArcanistConsoleLintRenderer.php

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/__tests__/data/remline.expect

src/lint/renderer/__tests__/data/remline.txt

Fix a similar lint rendering issue when trimming identical lines out of patches
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/tests/data/remline.expect

src/lint/renderer/tests/data/remline.txt