Update Create Diff page for new Edit UI
ClosedPublic
Actions

Authored by chad on Sep 4 2017, 11:45 PM.

Tags

None

Referenced Files

	F19098853: D18529.id44540.diff
	Thu, Dec 4, 6:24 PM

	F19098705: D18529.id44537.diff
	Thu, Dec 4, 5:41 PM

	F19098704: D18529.id44539.diff
	Thu, Dec 4, 5:41 PM

	F19098588: D18529.diff
	Thu, Dec 4, 5:09 PM

	F18845027: D18529.id44540.diff
	Oct 29 2025, 9:12 AM

	F18843039: D18529.id44537.diff
	Oct 28 2025, 8:35 PM

	F18836996: D18529.id44539.diff
	Oct 27 2025, 4:07 AM

	F18836305: D18529.diff
	Oct 26 2025, 11:51 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP818b90cf12d4: Update Create Diff page for new Edit UI

Summary

Create a diff page, new UI

Test Plan

Create a diff from page

Diff Detail

Repository

rP Phabricator

Branch

diff-edit-page (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18279
Build 24593: Run Core Tests
Build 24592: arc lint + arc unit

Event Timeline

chad created this revision.Sep 4 2017, 11:45 PM

Herald added a subscriber: Korvin. · View Herald TranscriptSep 4 2017, 11:45 PM

chad added a parent revision: D18527: Update EditEngine pages to take a page header separate.Sep 4 2017, 11:45 PM

Harbormaster completed remote builds in B18279: Diff 44495.Sep 4 2017, 11:46 PM

Maybe just delete $info_view if you don't think it deserves to be on top.

This revision is now accepted and ready to land.Sep 5 2017, 1:14 PM

rebase

Harbormaster completed remote builds in B18320: Diff 44537.Sep 6 2017, 5:07 PM

rebase #2

Harbormaster completed remote builds in B18322: Diff 44539.Sep 6 2017, 5:13 PM

Closed by commit rP818b90cf12d4: Update Create Diff page for new Edit UI (authored by Chad Little <chad@phacility.com>). · Explain WhySep 6 2017, 5:15 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D20092: Improve description text in the "Create Diff" form.Feb 5 2019, 1:04 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialDiffCreateController.php

11 lines

Diff 44495

View Options

src/applications/differential/controller/DifferentialDiffCreateController.php

Update Create Diff page for new Edit UIClosedPublicActions