Page MenuHomePhabricator
Differential D18529

Update Create Diff page for new Edit UI
ClosedPublic
Actions

Authored by chad on Sep 4 2017, 11:45 PM.
Tags
None
Referenced Files
F17662796: D18529.id44537.diff
Sat, Jul 12, 5:18 PM
F17653528: D18529.id44540.diff
Sat, Jul 12, 7:49 AM
F17630132: D18529.diff
Thu, Jul 10, 10:10 AM
Unknown Object (File)
Jun 12 2025, 11:38 AM
Unknown Object (File)
Jun 8 2025, 4:54 PM
Unknown Object (File)
Jun 7 2025, 6:46 PM
Unknown Object (File)
Jun 6 2025, 8:08 AM
Unknown Object (File)
Jun 1 2025, 10:37 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP818b90cf12d4: Update Create Diff page for new Edit UI
Summary

Create a diff page, new UI

Test Plan

Create a diff from page

Diff Detail

Repository
rP Phabricator
Branch
diff-edit-page
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18320
Build 24656: Run Core Tests
Build 24655: arc lint + arc unit

Event Timeline

chad created this revision.Sep 4 2017, 11:45 PM
Herald added a subscriber: Korvin. · View Herald TranscriptSep 4 2017, 11:45 PM
chad added a parent revision: D18527: Update EditEngine pages to take a page header separate.Sep 4 2017, 11:45 PM
Harbormaster completed remote builds in B18279: Diff 44495.Sep 4 2017, 11:46 PM
epriestley accepted this revision.Sep 5 2017, 1:14 PM

Maybe just delete $info_view if you don't think it deserves to be on top.

This revision is now accepted and ready to land.Sep 5 2017, 1:14 PM
chad updated this revision to Diff 44537.Sep 6 2017, 5:06 PM

rebase

Harbormaster completed remote builds in B18320: Diff 44537.Sep 6 2017, 5:07 PM
chad updated this revision to Diff 44539.Sep 6 2017, 5:12 PM
  • rebase #2
Harbormaster completed remote builds in B18322: Diff 44539.Sep 6 2017, 5:13 PM
Closed by commit rP818b90cf12d4: Update Create Diff page for new Edit UI (authored by Chad Little <chad@phacility.com>). · Explain WhySep 6 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D20092: Improve description text in the "Create Diff" form.Feb 5 2019, 1:04 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
differential/
controller/
11 lines
view/
phui/
1 line
4 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 44537

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffCreateController.php

Loading...
View Options

src/view/phui/PHUIInfoView.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility