Page MenuHomePhabricator

Improve description text in the "Create Diff" form
ClosedPublic

Authored by leoluk on Tue, Feb 5, 12:24 PM.

Details

Summary

The textarea is, in fact, above the description!

Test Plan

Description text changed.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

leoluk created this revision.Tue, Feb 5, 12:24 PM
leoluk requested review of this revision.Tue, Feb 5, 12:24 PM

How do you feel about putting this text box back above the form instead, i.e. partially reverting D18529?

leoluk added a comment.Tue, Feb 5, 1:39 PM

It's just a minor thing I was briefly confused about when I used the "Create Diff" for the first time.

IMO, the message is only useful for new users who do not know about Arcanist, and of no use to anyone who purposefully creates a diff, so it's fine to keep it at the bottom.

epriestley accepted this revision.Tue, Feb 5, 1:41 PM

I added you to Community and Blessed Committers, so you should be able to land this yourself. See the project description for Blessed Committers if you run into trouble, or let me know if that isn't helpful.

This revision is now accepted and ready to land.Tue, Feb 5, 1:41 PM
Closed by commit rPb8fe991ba28e: Improve description text in the "Create Diff" form (authored by Leopold Schabel <mail@leoschabel.de>). · Explain WhyTue, Feb 5, 1:48 PM
This revision was automatically updated to reflect the committed changes.
leoluk added a comment.Tue, Feb 5, 1:59 PM

Thanks, worked perfectly!

Just one quick question - could you rename this user to leoluk to match GitHub and the Discourse forums? There are no literal mentions anywhere.

Would've created a new account but since that's no longer a thing... :-)

Sure: I renamed existing user leoluk to leoluk-moved-aside, and then renamed lou to leoluk.

leoluk added a comment.Tue, Feb 5, 2:16 PM

Thanks, greatly appreciated.