Some header tag icons are too small
ClosedPublic
Actions

Authored by chad on Aug 25 2017, 2:11 AM.

Tags

None

Referenced Files

	F19035819: D18472.id44377.diff
	Tue, Nov 25, 6:13 PM

	F19035797: D18472.id44379.diff
	Tue, Nov 25, 6:11 PM

	F19032764: D18472.diff
	Tue, Nov 25, 7:23 AM

	F18863490: D18472.diff
	Sun, Nov 2, 11:43 PM

	F18842191: D18472.id44377.diff
	Tue, Oct 28, 1:48 PM

	F18828385: D18472.id.diff
	Oct 24 2025, 4:01 PM

	F18828182: D18472.id44379.diff
	Oct 24 2025, 2:51 PM

	F18821372: D18472.diff
	Oct 22 2025, 10:33 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley
avivey

Commits

rPc49896f7c5a7: Some header tag icons are too small

Summary

Ref D17991, this rule got more specific with shade tag re-write, so needs updating for headers.

Test Plan

Review a differential header, first icon is now 15px instead of 12px

Diff Detail

Repository

rP Phabricator

Branch

shade-icons (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18164
Build 24416: Run Core Tests
Build 24415: arc lint + arc unit

Event Timeline

chad created this revision.Aug 25 2017, 2:11 AM

Harbormaster completed remote builds in B18164: Diff 44377.Aug 25 2017, 2:11 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2017, 2:11 AM

Harbormaster completed remote builds in B18164: Diff 44377.Aug 25 2017, 2:12 AM

¯\_(ツ)_/¯

This revision is now accepted and ready to land.Aug 25 2017, 2:19 AM

Closed by commit rPc49896f7c5a7: Some header tag icons are too small (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 25 2017, 2:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-header-view.css

4 lines

Diff 44377

View Options

resources/celerity/map.php