Some header tag icons are too small
ClosedPublic
Actions

Authored by chad on Aug 25 2017, 2:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 3:23 AM

	Unknown Object (File)
	Sat, Nov 16, 11:18 PM

	Unknown Object (File)
	Tue, Nov 12, 8:20 PM

	Unknown Object (File)
	Fri, Nov 1, 6:25 AM

	Unknown Object (File)
	Oct 16 2024, 4:49 PM

	Unknown Object (File)
	Sep 15 2024, 7:51 PM

	Unknown Object (File)
	Sep 6 2024, 4:00 PM

	Unknown Object (File)
	Sep 6 2024, 12:57 AM

View All 90 Files

Subscribers

Korvin

Details

Reviewers

epriestley
avivey

Commits

rPc49896f7c5a7: Some header tag icons are too small

Summary

Ref D17991, this rule got more specific with shade tag re-write, so needs updating for headers.

Test Plan

Review a differential header, first icon is now 15px instead of 12px

Diff Detail

Repository

rP Phabricator

Branch

shade-icons (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18164
Build 24416: Run Core Tests
Build 24415: arc lint + arc unit

Event Timeline

chad created this revision.Aug 25 2017, 2:11 AM

Harbormaster completed remote builds in B18164: Diff 44377.Aug 25 2017, 2:11 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2017, 2:11 AM

Harbormaster completed remote builds in B18164: Diff 44377.Aug 25 2017, 2:12 AM

¯\_(ツ)_/¯

This revision is now accepted and ready to land.Aug 25 2017, 2:19 AM

Closed by commit rPc49896f7c5a7: Some header tag icons are too small (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 25 2017, 2:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-header-view.css

4 lines

Diff 44377

View Options

resources/celerity/map.php