Page MenuHomePhabricator
Differential D17991

Add Outline tag type to PHUITagView
ClosedPublic
Actions

Authored by chad on May 22 2017, 4:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 22, 10:30 AM
Unknown Object (File)
Sun, Feb 9, 4:11 AM
Unknown Object (File)
Sun, Feb 9, 4:11 AM
Unknown Object (File)
Sun, Feb 9, 4:11 AM
Unknown Object (File)
Sun, Feb 9, 4:11 AM
Unknown Object (File)
Sun, Feb 9, 4:11 AM
Unknown Object (File)
Jan 30 2025, 9:42 AM
Unknown Object (File)
Jan 27 2025, 11:13 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP5d966897f14a: Add Outline tag type to PHUITagView
Summary

Adds a new tag type, starts to try to clean up the mess that are PHUITags

Test Plan

Review UIExamples.

image.png (1×704 px, 126 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.May 22 2017, 4:49 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 22 2017, 4:49 PM
chad edited the test plan for this revision. (Show Details)May 22 2017, 4:49 PM
Harbormaster completed remote builds in B17182: Diff 43265.May 22 2017, 4:50 PM
chad updated this revision to Diff 43266.May 22 2017, 5:04 PM
  • test maniphest, object lists, embedding projects, users
Harbormaster completed remote builds in B17183: Diff 43266.May 22 2017, 5:05 PM
epriestley accepted this revision.May 22 2017, 5:15 PM
epriestley added inline comments.
src/applications/uiexample/examples/PHUITagExample.php
192

  in 2017 LUL

This revision is now accepted and ready to land.May 22 2017, 5:15 PM
chad added a comment.May 22 2017, 5:16 PM

this probably breaks something but I couldn't find anything offhand major.

Closed by commit rP5d966897f14a: Add Outline tag type to PHUITagView (authored by chad, committed by chad). · Explain WhyMay 22 2017, 5:16 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 22 2017, 5:37 PM

I'll keep an eye out. <_< >_>

chad mentioned this in D18472: Some header tag icons are too small.Aug 25 2017, 2:11 AM
chad mentioned this in rPc49896f7c5a7: Some header tag icons are too small.Aug 25 2017, 2:30 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
phid/
4 lines
view/
4 lines
uiexample/
examples/
34 lines
view/
phui/
53 lines
webroot/
rsrc/
css/
phui/
173 lines

Diff 43267

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/phid/view/PHUIHandleTagListView.php

Loading...
View Options

src/applications/uiexample/examples/PHUITagExample.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
Phabricator · Built by Phacility