Page MenuHomePhabricator

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 9:28 AM
Unknown Object (File)
Tue, Jan 28, 8:45 PM
Unknown Object (File)
Tue, Jan 21, 9:28 AM
Unknown Object (File)
Fri, Jan 3, 9:09 AM
Unknown Object (File)
Dec 17 2024, 11:05 AM
Unknown Object (File)
Dec 16 2024, 1:59 AM
Unknown Object (File)
Dec 14 2024, 4:38 AM
Unknown Object (File)
Dec 8 2024, 10:12 AM
Subscribers
None

Details

Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable