Page MenuHomePhabricator

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic

Authored by epriestley on Aug 11 2017, 10:39 PM.
Tags
None
Referenced Files
F14495583: D18413.diff
Fri, Jan 3, 9:09 AM
Unknown Object (File)
Tue, Dec 17, 11:05 AM
Unknown Object (File)
Mon, Dec 16, 1:59 AM
Unknown Object (File)
Sat, Dec 14, 4:38 AM
Unknown Object (File)
Sun, Dec 8, 10:12 AM
Unknown Object (File)
Dec 3 2024, 1:55 PM
Unknown Object (File)
Nov 13 2024, 6:12 AM
Unknown Object (File)
Nov 12 2024, 4:15 PM
Subscribers
None

Details

Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable