Page MenuHomePhabricator
Differential D18413

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 10:39 PM.
Tags
None
Referenced Files
F13061008: D18413.diff
Fri, Apr 19, 6:44 PM
Unknown Object (File)
Fri, Apr 19, 6:08 AM
Unknown Object (File)
Fri, Apr 12, 9:07 AM
Unknown Object (File)
Wed, Apr 10, 1:50 AM
Unknown Object (File)
Mon, Apr 8, 12:20 PM
Unknown Object (File)
Wed, Apr 3, 6:55 PM
Unknown Object (File)
Sat, Mar 30, 4:58 AM
Unknown Object (File)
Feb 1 2024, 11:00 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP7f743c14d532: Remove remaining ArcanistDifferentialRevisionStatus references in revision…
Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository
rP Phabricator
Branch
status14
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/editor/DifferentialTransactionEditor.php:556XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 18040
Build 24230: Run Core Tests
Build 24229: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
199 lines
storage/
19 lines

Diff 44248

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
Phabricator · Built by Phacility