Paths

Table of Contentst

Differential D18413

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 10:39 PM.

Details

Reviewers

chad

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP7f743c14d532: Remove remaining ArcanistDifferentialRevisionStatus references in revision…

Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan

Updated revisions, saw them go to "Needs Review".
Accepted, requested changes to revisions.
Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository

rP Phabricator

Branch

status14

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/editor/DifferentialTransactionEditor.php:556	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 18040
Build 24230: Run Core Tests
Build 24229: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 10:39 PM

Harbormaster completed remote builds in B18040: Diff 44248.Aug 11 2017, 10:41 PM

chad accepted this revision.Aug 11 2017, 10:46 PM

This revision is now accepted and ready to land.Aug 11 2017, 10:46 PM

Closed by commit rP7f743c14d532: Remove remaining ArcanistDifferentialRevisionStatus references in revision… (authored by epriestley, committed by epriestley). · Explain WhyAug 12 2017, 12:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

199 lines

storage/

DifferentialRevision.php

19 lines

Diff 44248

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php