Page MenuHomePhabricator

Convert straggling Herald rules to modern revision status constants
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:06 PM.
Tags
None
Referenced Files
F19947293: D18416.diff
Fri, Apr 17, 5:43 AM
F19939993: D18416.id44260.diff
Tue, Apr 14, 8:41 PM
F19909675: D18416.diff
Thu, Apr 2, 1:42 AM
F19784567: D18416.diff
Feb 24 2026, 8:29 PM
F19605402: D18416.diff
Feb 3 2026, 9:16 AM
F19605399: D18416.diff
Feb 3 2026, 9:16 AM
F19239167: D18416.id44260.diff
Dec 21 2025, 8:43 PM
F19239161: D18416.id44260.diff
Dec 21 2025, 8:42 PM
Subscribers
None

Details

Summary

Ref T2543. These are the last ArcanistDifferentialRevisionStatus callsites.

This removes the very old legacy precommitRevisionStatus field, which has no other readers. This was obsoleted by the CLOSED_FROM_ACCEPTED stuff, but retained for compatibility.

Test Plan
  • Poked these with the test console, although they're a little tricky to be sure about.
  • Grepped for ArcanistDifferentialRevisionStatus, no more hits.

Diff Detail

Repository
rP Phabricator
Branch
status17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18043
Build 24236: Run Core Tests
Build 24235: arc lint + arc unit