Page MenuHomePhabricator

Convert straggling Herald rules to modern revision status constants
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:06 PM.

Details

Summary

Ref T2543. These are the last ArcanistDifferentialRevisionStatus callsites.

This removes the very old legacy precommitRevisionStatus field, which has no other readers. This was obsoleted by the CLOSED_FROM_ACCEPTED stuff, but retained for compatibility.

Test Plan
  • Poked these with the test console, although they're a little tricky to be sure about.
  • Grepped for ArcanistDifferentialRevisionStatus, no more hits.

Diff Detail

Repository
rP Phabricator
Branch
status17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18043
Build 24236: Run Core Tests
Build 24235: arc lint + arc unit