Page MenuHomePhabricator

Convert straggling Herald rules to modern revision status constants
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:06 PM.
Tags
None
Referenced Files
F21203936: D18416.diff
Sun, Jul 5, 8:53 AM
Unknown Object (File)
Fri, Jun 19, 9:38 PM
Unknown Object (File)
Apr 17 2026, 5:43 AM
Unknown Object (File)
Apr 14 2026, 8:41 PM
Unknown Object (File)
Apr 2 2026, 1:42 AM
Unknown Object (File)
Feb 24 2026, 8:29 PM
Unknown Object (File)
Feb 3 2026, 9:16 AM
Unknown Object (File)
Feb 3 2026, 9:16 AM
Subscribers
None

Details

Summary

Ref T2543. These are the last ArcanistDifferentialRevisionStatus callsites.

This removes the very old legacy precommitRevisionStatus field, which has no other readers. This was obsoleted by the CLOSED_FROM_ACCEPTED stuff, but retained for compatibility.

Test Plan
  • Poked these with the test console, although they're a little tricky to be sure about.
  • Grepped for ArcanistDifferentialRevisionStatus, no more hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable