Page MenuHomePhabricator

Convert straggling Herald rules to modern revision status constants
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 2:46 PM
Unknown Object (File)
Feb 9 2024, 3:24 AM
Unknown Object (File)
Feb 1 2024, 11:04 PM
Unknown Object (File)
Dec 27 2023, 11:51 AM
Unknown Object (File)
Dec 27 2023, 11:51 AM
Unknown Object (File)
Dec 27 2023, 11:51 AM
Unknown Object (File)
Dec 24 2023, 1:00 AM
Unknown Object (File)
Dec 21 2023, 8:34 PM
Subscribers
None

Details

Summary

Ref T2543. These are the last ArcanistDifferentialRevisionStatus callsites.

This removes the very old legacy precommitRevisionStatus field, which has no other readers. This was obsoleted by the CLOSED_FROM_ACCEPTED stuff, but retained for compatibility.

Test Plan
  • Poked these with the test console, although they're a little tricky to be sure about.
  • Grepped for ArcanistDifferentialRevisionStatus, no more hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable