Page MenuHomePhabricator
Differential D18413

Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 10:39 PM.
Tags
None
Referenced Files
F17849682: D18413.id44257.diff
Sun, Jul 27, 8:59 AM
F17848824: D18413.id44248.diff
Sun, Jul 27, 7:50 AM
F17839028: D18413.id44248.diff
Sat, Jul 26, 7:28 PM
F17817228: D18413.diff
Fri, Jul 25, 11:23 PM
F17644241: D18413.diff
Fri, Jul 11, 10:22 PM
Unknown Object (File)
Wed, Jul 2, 4:57 AM
Unknown Object (File)
Jun 5 2025, 10:37 PM
Unknown Object (File)
Jun 3 2025, 11:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP7f743c14d532: Remove remaining ArcanistDifferentialRevisionStatus references in revision…
Summary

Ref T2543. This cleans up all the "when no one is rejecting/blocking and someone accepted, mark the revision overall as accepted" logic to use more modern status stuff instead of ArcanistDifferentialRevisionStatus.

Test Plan
  • Updated revisions, saw them go to "Needs Review".
  • Accepted, requested changes to revisions.
  • Updated one with changes requested, saw it go to "needs review" again.

Diff Detail

Repository
rP Phabricator
Branch
status14
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/editor/DifferentialTransactionEditor.php:556XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 18040
Build 24230: Run Core Tests
Build 24229: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
199 lines
storage/
19 lines

Diff 44248

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
Phabricator · Built by Phacility