Page MenuHomePhabricator

Fix a hang in fancy date picker for Ye Olde Time Years
ClosedPublic

Authored by epriestley on Aug 10 2017, 10:36 AM.
Tags
None
Referenced Files
F19472234: D18383.id44182.diff
Wed, Jan 7, 2:45 AM
F19269060: D18383.id.diff
Mon, Dec 22, 9:22 PM
F19239927: D18383.diff
Sun, Dec 21, 9:09 PM
F19053170: D18383.id44182.diff
Nov 28 2025, 7:44 AM
F19002893: D18383.id44181.diff
Nov 21 2025, 7:04 AM
F18962468: D18383.diff
Nov 13 2025, 5:06 PM
F18875251: D18383.id.diff
Nov 5 2025, 5:08 PM
F18805052: D18383.id44182.diff
Oct 18 2025, 1:29 PM
Subscribers
None
Tokens
"Pterodactyl" token, awarded by avivey.

Details

Summary

Fixes T12960. When the user enters a date like "1917", we currently loop ~20 million times.

Instead:

  • Be a little more careful about parsing.
  • Javascript's default behavior of interpreting "2001-02-31" as "2001-03-03" ("February 31" -> "March 3") already seems reasonable, so just let it do that.
Test Plan

Verified these behaviors:

  • 2017-08-08 - Valid, recent.
  • 17-08-08 - Valid, recent.
  • 1917-08-08 - Valid, a century ago, no loop.
  • 2017-02-31 - "February 31", interpreted as "March 3" by Javascsript, seems reasonable.
  • Quack - Default, current time.
  • 0/0/0, 0/99/0 - Default, current time.

Diff Detail

Repository
rP Phabricator
Branch
date1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17977
Build 24141: Run Core Tests
Build 24140: arc lint + arc unit