Page MenuHomePhabricator

Fix a hang in fancy date picker for Ye Olde Time Years
ClosedPublic

Authored by epriestley on Aug 10 2017, 10:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 3:35 PM
Unknown Object (File)
Sat, Apr 27, 1:31 PM
Unknown Object (File)
Sat, Apr 27, 11:18 AM
Unknown Object (File)
Wed, Apr 24, 10:50 PM
Unknown Object (File)
Wed, Apr 24, 6:55 AM
Unknown Object (File)
Wed, Apr 24, 6:55 AM
Unknown Object (File)
Sun, Apr 21, 5:01 PM
Unknown Object (File)
Thu, Apr 11, 7:43 AM
Subscribers
None
Tokens
"Pterodactyl" token, awarded by avivey.

Details

Summary

Fixes T12960. When the user enters a date like "1917", we currently loop ~20 million times.

Instead:

  • Be a little more careful about parsing.
  • Javascript's default behavior of interpreting "2001-02-31" as "2001-03-03" ("February 31" -> "March 3") already seems reasonable, so just let it do that.
Test Plan

Verified these behaviors:

  • 2017-08-08 - Valid, recent.
  • 17-08-08 - Valid, recent.
  • 1917-08-08 - Valid, a century ago, no loop.
  • 2017-02-31 - "February 31", interpreted as "March 3" by Javascsript, seems reasonable.
  • Quack - Default, current time.
  • 0/0/0, 0/99/0 - Default, current time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable