Fix a hang in fancy date picker for Ye Olde Time Years
ClosedPublic
Actions

Authored by epriestley on Aug 10 2017, 10:36 AM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T12960: fancy date picker breaks browser if year < 1970

Commits

Summary

Fixes T12960. When the user enters a date like "1917", we currently loop ~20 million times.

Instead:

Be a little more careful about parsing.
Javascript's default behavior of interpreting "2001-02-31" as "2001-03-03" ("February 31" -> "March 3") already seems reasonable, so just let it do that.

Test Plan

Verified these behaviors:

2017-08-08 - Valid, recent.
17-08-08 - Valid, recent.
1917-08-08 - Valid, a century ago, no loop.
2017-02-31 - "February 31", interpreted as "March 3" by Javascsript, seems reasonable.
Quack - Default, current time.
0/0/0, 0/99/0 - Default, current time.

Repository

rP Phabricator

Branch

date1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

	Time	Test
	236 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	1 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 4 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 2 assertions passed.
		View Full Test Results (1 Failed · 336 Passed)