Page MenuHomePhabricator
Differential D18378

Remove chatbot example configuration
ClosedPublic
Actions

Authored by joshuaspence on Aug 9 2017, 10:11 PM.
Tags
None
Referenced Files
F14448655: D18378.diff
Thu, Dec 26, 5:51 PM
Unknown Object (File)
Sun, Dec 15, 5:08 PM
Unknown Object (File)
Sat, Dec 14, 6:34 PM
Unknown Object (File)
Sun, Dec 8, 3:17 PM
Unknown Object (File)
Sun, Dec 1, 10:48 PM
Unknown Object (File)
Nov 26 2024, 4:54 PM
Unknown Object (File)
Nov 26 2024, 4:23 PM
Unknown Object (File)
Nov 26 2024, 12:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPbd47d001b548: Remove chatbot example configuration
Summary

This is no longer needed after the chatbot was removed in D17756.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 17969
Build 24127: Run Core Tests
Build 24126: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Aug 9 2017, 10:11 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 9 2017, 10:11 PM
Herald added a subscriber: Korvin. · View Herald Transcript
Harbormaster completed remote builds in B17969: Diff 44170.Aug 9 2017, 10:12 PM
epriestley accepted this revision.Aug 9 2017, 10:34 PM
This revision is now accepted and ready to land.Aug 9 2017, 10:34 PM
joshuaspence added a comment.Aug 9 2017, 10:49 PM

(interestingly, I didn't receive an email about this diff being accepted)

Closed by commit rPbd47d001b548: Remove chatbot example configuration (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 9 2017, 10:49 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Aug 9 2017, 10:51 PM

! joshuaspence (Joshua Spence)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

joshuaspence added inline comments.Aug 9 2017, 10:52 PM
src/applications/files/storage/PhabricatorFile.php
857 ↗(On Diff #44172)

Oh wtf. This wasn't in the diff. I used "Land Revision"

joshuaspence added a comment.Aug 9 2017, 10:52 PM
In D18378#224025, @epriestley wrote:

! joshuaspence (Joshua Spence)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

Ah right, thanks

src/applications/files/storage/PhabricatorFile.php
857 ↗(On Diff #44172)

I'll revert when I get back to mylaptop

epriestley added a comment.Aug 9 2017, 10:54 PM

If you put change X on master, then change Y, then arc diff X, the web UI will show Y but "land revision" will land X + Y. This is bad/confusing but not trivial to fix since the web UI and staging area don't really know about one another right now.

epriestley added a comment.Aug 9 2017, 10:55 PM

Sounds good, doesn't look like it'll break anything anyway. I'll send you a revert if I get there first.

joshuaspence mentioned this in D18380: Remove code that was accidentally landed.Aug 9 2017, 11:02 PM
joshuaspence mentioned this in rP71eaf3e8c4d6: Remove code that was accidentally landed.Aug 10 2017, 8:45 AM

Revision Contents
Changeset List

PathSize
resources/
chatbot/

Diff 44170

View Options

resources/chatbot/example_config.json

Loading...
Phabricator · Built by Phacility