Remove incorrect policy language on Diff reviewers
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 2:34 AM.

Tags

None

Referenced Files

	F15416107: D18349.id44109.diff
	Thu, Mar 20, 9:19 AM

	F15410983: D18349.id.diff
	Wed, Mar 19, 8:45 AM

	F15404452: D18349.diff
	Tue, Mar 18, 7:46 AM

	F15400739: D18349.diff
	Mon, Mar 17, 1:41 PM

	F15355558: D18349.diff
	Tue, Mar 11, 5:55 AM

	Unknown Object (File)
	Feb 17 2025, 5:57 PM

	Unknown Object (File)
	Feb 8 2025, 11:56 PM

	Unknown Object (File)
	Jan 28 2025, 2:46 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12952: Reviewer not able to see diff

Commits

rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers

Summary

Fixes T12952. This never work AFAIK, so resolves this mis-information. See T4411 for follow up.

Test Plan

Click on policy for a diff, no longer see text.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:34 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:35 AM

epriestley accepted this revision.Aug 6 2017, 11:44 AM

This revision is now accepted and ready to land.Aug 6 2017, 11:44 AM

Closed by commit rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers (authored by chad, committed by chad). · Explain WhyAug 6 2017, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

1 line

Diff 44109

View Options

src/applications/differential/storage/DifferentialRevision.php

Remove incorrect policy language on Diff reviewersClosedPublicActions