Remove incorrect policy language on Diff reviewers
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 2:34 AM.

Tags

None

Referenced Files

	F19824638: D18349.diff
	Sun, Mar 8, 1:50 AM

	F19819178: D18349.id44103.diff
	Fri, Mar 6, 3:54 AM

	F19819099: D18349.diff
	Fri, Mar 6, 2:54 AM

	F19671582: D18349.id.diff
	Sun, Feb 8, 1:21 AM

	F19516334: D18349.diff
	Jan 14 2026, 10:58 PM

	F19469531: D18349.id44103.diff
	Jan 5 2026, 12:11 AM

	F19466033: D18349.diff
	Jan 3 2026, 7:27 AM

	F19303031: D18349.id44103.diff
	Dec 23 2025, 4:41 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12952: Reviewer not able to see diff

Commits

rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers

Summary

Fixes T12952. This never work AFAIK, so resolves this mis-information. See T4411 for follow up.

Test Plan

Click on policy for a diff, no longer see text.

Diff Detail

Repository

rP Phabricator

Branch

diff-reviewer-language (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17922
Build 24071: Run Core Tests
Build 24070: arc lint + arc unit

Event Timeline

chad created this revision.Aug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:34 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:35 AM

epriestley accepted this revision.Aug 6 2017, 11:44 AM

This revision is now accepted and ready to land.Aug 6 2017, 11:44 AM

Closed by commit rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers (authored by chad, committed by chad). · Explain WhyAug 6 2017, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

1 line

Diff 44103

View Options

src/applications/differential/storage/DifferentialRevision.php

Remove incorrect policy language on Diff reviewersClosedPublicActions