Page MenuHomePhabricator

Update Settings to use full side-navigation
ClosedPublic

Authored by chad on Aug 4 2017, 5:19 PM.
Tags
None
Referenced Files
F13345079: D18342.diff
Fri, Jun 21, 9:28 AM
F13330427: D18342.diff
Mon, Jun 17, 3:37 AM
F13317757: D18342.diff
Thu, Jun 13, 9:52 AM
F13303912: D18342.diff
Sat, Jun 8, 7:34 AM
F13288597: D18342.diff
Tue, Jun 4, 10:39 AM
F13286035: D18342.diff
Tue, Jun 4, 6:07 AM
F13271258: D18342.diff
Wed, May 29, 7:05 PM
F13267186: D18342.id44095.diff
Wed, May 29, 2:45 AM
Subscribers

Details

Summary

Moves Settings to use a normal side navigation vs. a two column side navigation. It also updates Edit Engine to do the same, but I don't think there are other callsites. Added a consistent header for better clarification if you were editng your settings, global settings, or a bot's settings.

Test Plan

Test each page on a personal account, create global settings, test each page there, create a bot account, and test each page on the bot account. Anything else?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 4 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Is this "normal side navigation" used anywhere else? It looks a little strange:

image.png (443×432 px, 24 KB)

I expect to use that style in config and settings, places that are more 'under the hood' and need better navigation.