Page MenuHomePhabricator

Update Settings to use full side-navigation
ClosedPublic

Authored by chad on Aug 4 2017, 5:19 PM.
Tags
None
Referenced Files
F17702355: D18342.id44095.diff
Tue, Jul 15, 10:40 PM
F17686134: D18342.id44096.diff
Mon, Jul 14, 4:54 AM
Unknown Object (File)
Sat, Jul 5, 6:20 AM
Unknown Object (File)
Fri, Jun 27, 9:12 AM
Unknown Object (File)
Sun, Jun 22, 7:20 PM
Unknown Object (File)
May 2 2025, 5:50 AM
Unknown Object (File)
May 1 2025, 3:16 AM
Unknown Object (File)
Apr 24 2025, 2:54 AM
Subscribers

Details

Summary

Moves Settings to use a normal side navigation vs. a two column side navigation. It also updates Edit Engine to do the same, but I don't think there are other callsites. Added a consistent header for better clarification if you were editng your settings, global settings, or a bot's settings.

Test Plan

Test each page on a personal account, create global settings, test each page there, create a bot account, and test each page on the bot account. Anything else?

Diff Detail

Repository
rP Phabricator
Branch
settings-new-ui-aug-2017 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17910
Build 24054: Run Core Tests
Build 24053: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 4 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Is this "normal side navigation" used anywhere else? It looks a little strange:

image.png (443×432 px, 24 KB)

I expect to use that style in config and settings, places that are more 'under the hood' and need better navigation.