Paths

Table of Contentst

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run
ClosedPublic
Actions

Authored by epriestley on Jul 18 2017, 3:51 PM.

Tags

None

Referenced Files

	F15467379: D18233.id43865.diff
	Thu, Apr 3, 2:16 PM

	F15467113: D18233.id43856.diff
	Thu, Apr 3, 12:52 PM

	F15455965: D18233.diff
	Sun, Mar 30, 6:02 AM

	F15452367: D18233.id43856.diff
	Sat, Mar 29, 4:15 AM

	F15443304: D18233.id43865.diff
	Thu, Mar 27, 3:36 AM

	F15439065: D18233.id43865.diff
	Wed, Mar 26, 5:30 AM

	F15438391: D18233.id.diff
	Wed, Mar 26, 12:28 AM

	F15431803: D18233.diff
	Mon, Mar 24, 2:36 PM

View All Files

Subscribers

None

Details

Reviewers

chad
amckinley

Maniphest Tasks

T10769: Read-Only Mode Errata

Commits

rP4d1ed12a9e0a: Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run

Summary

Ref T10769. See PHI8. We have an unconditional logging write which we can skip in read-only mode.

Test Plan

Put Phabricator in read-only mode with cluster.read-only.
Called conduit.ping via web UI.
- Before: write-on-read-only exception.
- After: good result.

Diff Detail

Repository

rP Phabricator

Branch

ping1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17721
Build 23792: Run Core Tests
Build 23791: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 18 2017, 3:51 PM

Harbormaster completed remote builds in B17721: Diff 43856.Jul 18 2017, 3:52 PM

chad accepted this revision.Jul 18 2017, 8:31 PM

This revision is now accepted and ready to land.Jul 18 2017, 8:31 PM

Closed by commit rP4d1ed12a9e0a: Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run (authored by epriestley, committed by epriestley). · Explain WhyJul 18 2017, 8:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

controller/

PhabricatorConduitAPIController.php

8 lines

Diff 43856

View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to runClosedPublicActions