HomePhabricator

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run

Authored by epriestley on Jul 18 2017, 3:49 PM.

Description

Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run

Summary: Ref T10769. See PHI8. We have an unconditional logging write which we can skip in read-only mode.

Test Plan:

  • Put Phabricator in read-only mode with cluster.read-only.
  • Called conduit.ping via web UI.
    • Before: write-on-read-only exception.
    • After: good result.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T10769

Differential Revision: https://secure.phabricator.com/D18233

Details

Committed
epriestleyJul 18 2017, 8:32 PM
Pushed
epriestleyJul 18 2017, 8:32 PM
Reviewer
chad
Differential Revision
D18233: Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run
Parents
rPd1f144b214df: Fix Search Application Config
Branches
Unknown
Tags
Unknown
Tasks
T10769: Read-Only Mode Errata
Build Status
Buildable 17729
Build 23803: Run Core Tests