Fix Search Application Config
ClosedPublic
Actions

Authored by avivey on Jul 17 2017, 11:43 PM.

Tags

None

Referenced Files

	F15473111: D18230.diff
	Sat, Apr 5, 7:38 PM

	F15470404: D18230.id.diff
	Fri, Apr 4, 9:48 PM

	F15425493: D18230.id.diff
	Sun, Mar 23, 4:48 AM

	F15418200: D18230.id43849.diff
	Thu, Mar 20, 9:31 PM

	F15397961: D18230.id43849.diff
	Sun, Mar 16, 11:04 PM

	F15389212: D18230.id.diff
	Sat, Mar 15, 5:00 AM

	F15336658: D18230.id43849.diff
	Mar 8 2025, 8:22 PM

	Unknown Object (File)
	Mar 3 2025, 7:41 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley
20after4

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12924: Applications -> Search -> Configure is fataling

Commits

rPd1f144b214df: Fix Search Application Config

Summary

Fix T12924. Looks like this melted in D17384, and nobody noticed yet.

Test Plan

Visit page, see fancy table.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17716
Build 23786: Run Core Tests
Build 23785: arc lint + arc unit

Event Timeline

avivey created this revision.Jul 17 2017, 11:43 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 17 2017, 11:43 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Harbormaster completed remote builds in B17716: Diff 43849.Jul 17 2017, 11:44 PM

looks good to me and confirmed to work by testing locally on my test instance running upstream master branch.

epriestley accepted this revision.Jul 18 2017, 9:28 AM

This revision is now accepted and ready to land.Jul 18 2017, 9:28 AM

Closed by commit rPd1f144b214df: Fix Search Application Config (authored by avivey, committed by avivey). · Explain WhyJul 18 2017, 5:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

applicationpanel/

PhabricatorSearchApplicationStorageEnginePanel.php

47 lines

Diff 43849

View Options

src/applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php

Fix Search Application ConfigClosedPublicActions