Page MenuHomePhabricator
Differential D18230

Fix Search Application Config
ClosedPublic
Actions

Authored by avivey on Jul 17 2017, 11:43 PM.
Tags
None
Referenced Files
F17927362: D18230.id43860.diff
Wed, Jul 30, 2:30 PM
F17924551: D18230.id43860.diff
Wed, Jul 30, 10:12 AM
F17868190: D18230.diff
Mon, Jul 28, 7:21 AM
F17803749: D18230.id.diff
Fri, Jul 25, 10:34 AM
F17771556: D18230.id.diff
Wed, Jul 23, 12:05 PM
Unknown Object (File)
Jun 19 2025, 8:22 PM
Unknown Object (File)
Jun 18 2025, 9:56 PM
Unknown Object (File)
Jun 17 2025, 10:48 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
20after4
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T12924: Applications -> Search -> Configure is fataling
Commits
rPd1f144b214df: Fix Search Application Config
Summary

Fix T12924. Looks like this melted in D17384, and nobody noticed yet.

Test Plan

Visit page, see fancy table.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17716
Build 23786: Run Core Tests
Build 23785: arc lint + arc unit

Event Timeline

avivey created this revision.Jul 17 2017, 11:43 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 17 2017, 11:43 PM
Herald added a subscriber: Korvin. · View Herald Transcript
Harbormaster completed remote builds in B17716: Diff 43849.Jul 17 2017, 11:44 PM
20after4 accepted this revision.Jul 18 2017, 1:30 AM

looks good to me and confirmed to work by testing locally on my test instance running upstream master branch.

epriestley accepted this revision.Jul 18 2017, 9:28 AM
This revision is now accepted and ready to land.Jul 18 2017, 9:28 AM
Closed by commit rPd1f144b214df: Fix Search Application Config (authored by avivey, committed by avivey). · Explain WhyJul 18 2017, 5:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
applicationpanel/
47 lines

Diff 43849

View Options

src/applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php

Loading...
Phabricator · Built by Phacility