Page MenuHomePhabricator
Differential D18160

Move 'set' config option type to new structure
ClosedPublic
Actions

Authored by epriestley on Jun 26 2017, 5:27 PM.
Tags
None
Referenced Files
F15564840: D18160.id43689.diff
Wed, Apr 30, 4:29 PM
F15563848: D18160.id43696.diff
Wed, Apr 30, 10:13 AM
F15562893: D18160.id43695.diff
Wed, Apr 30, 4:54 AM
F15561705: D18160.diff
Tue, Apr 29, 9:43 PM
F15551735: D18160.id43688.diff
Sun, Apr 27, 6:13 PM
F15524229: D18160.diff
Mon, Apr 21, 6:43 AM
F15515169: D18160.id43689.diff
Fri, Apr 18, 8:17 AM
F15454195: D18160.id43688.diff
Mar 29 2025, 4:54 PM
View All Files
Subscribers
None

Details

Reviewers
chad
amckinley
Maniphest Tasks
T12845: Convert remaining ancient configuration type classes to modern modular type classes
Commits
rPec2af086254b: Move 'set' config option type to new structure
Summary

Ref T12845. This move 'set' options (a set of values).

Test Plan

Set, deleted and mangled 'set' options from CLI and web UI.

Diff Detail

Repository
rP Phabricator
Branch
config6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17587
Build 23607: Run Core Tests
Build 23606: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 26 2017, 5:27 PM
Harbormaster completed remote builds in B17579: Diff 43688.Jun 26 2017, 5:27 PM
Harbormaster completed remote builds in B17579: Diff 43688.
amckinley accepted this revision.Jun 26 2017, 6:43 PM

Just remove unused variable and this is g2g.

src/applications/config/type/PhabricatorSetConfigType.php
39

Technically, there's no such thing as a JSON set?

80

Unused variable.

82

This took a minute to grok, but this is because our set type is really just a regular JSON list that gets converted into a PHP array that maps all keys to true, right?

This revision is now accepted and ready to land.Jun 26 2017, 6:43 PM
epriestley updated this revision to Diff 43689.Jun 26 2017, 9:21 PM
  • No-op? Not sure how far this got before my internet cut out.
Harbormaster completed remote builds in B17580: Diff 43689.Jun 26 2017, 9:22 PM
epriestley added a comment.Jun 26 2017, 9:28 PM

Er, which variable?

src/applications/config/type/PhabricatorSetConfigType.php
39

I'll wordsmith this, it's a little copy/pastey.

82

$v is used here.

89

$k is used here.

amckinley added inline comments.Jun 26 2017, 9:37 PM
src/applications/config/type/PhabricatorSetConfigType.php
82

Oh whoops, I tagged the wrong line. It's one up, $expect_key.

epriestley added a comment.Jun 26 2017, 9:41 PM

Ohh, of course. Yeah, this one ended up a little copy-pastey in general.

epriestley updated this revision to Diff 43695.Jun 27 2017, 1:21 PM
  • Wordsmith.
  • Remove unused variable.
Harbormaster completed remote builds in B17586: Diff 43695.Jun 27 2017, 1:22 PM
epriestley updated this revision to Diff 43696.Jun 27 2017, 1:30 PM
  • Remove slightly more code.
Harbormaster completed remote builds in B17587: Diff 43696.Jun 27 2017, 1:31 PM
Closed by commit rPec2af086254b: Move 'set' config option type to new structure (authored by epriestley, committed by epriestley). · Explain WhyJun 27 2017, 7:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43696

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

Loading...
View Options

src/applications/config/option/PhabricatorApplicationConfigOptions.php

Loading...
View Options

src/applications/config/type/PhabricatorSetConfigType.php

Loading...
Phabricator · Built by Phacility