Ref T12845. This move 'set' options (a set of values).
Details
Details
Set, deleted and mangled 'set' options from CLI and web UI.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- config6
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17580 Build 23595: Run Core Tests Build 23594: arc lint + arc unit
Event Timeline
Comment Actions
Just remove unused variable and this is g2g.
src/applications/config/type/PhabricatorSetConfigType.php | ||
---|---|---|
39 | Technically, there's no such thing as a JSON set? | |
80 | Unused variable. | |
82 | This took a minute to grok, but this is because our set type is really just a regular JSON list that gets converted into a PHP array that maps all keys to true, right? |
src/applications/config/type/PhabricatorSetConfigType.php | ||
---|---|---|
81 | Oh whoops, I tagged the wrong line. It's one up, $expect_key. |