Page MenuHomePhabricator

Move 'set' config option type to new structure
ClosedPublic

Authored by epriestley on Jun 26 2017, 5:27 PM.

Details

Summary

Ref T12845. This move 'set' options (a set of values).

Test Plan

Set, deleted and mangled 'set' options from CLI and web UI.

Diff Detail

Repository
rP Phabricator
Branch
config6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17586
Build 23605: Run Core Tests
Build 23604: arc lint + arc unit

Event Timeline

Just remove unused variable and this is g2g.

src/applications/config/type/PhabricatorSetConfigType.php
39

Technically, there's no such thing as a JSON set?

80

Unused variable.

82

This took a minute to grok, but this is because our set type is really just a regular JSON list that gets converted into a PHP array that maps all keys to true, right?

This revision is now accepted and ready to land.Jun 26 2017, 6:43 PM
  • No-op? Not sure how far this got before my internet cut out.

Er, which variable?

src/applications/config/type/PhabricatorSetConfigType.php
39

I'll wordsmith this, it's a little copy/pastey.

82

$v is used here.

89

$k is used here.

src/applications/config/type/PhabricatorSetConfigType.php
82

Oh whoops, I tagged the wrong line. It's one up, $expect_key.

Ohh, of course. Yeah, this one ended up a little copy-pastey in general.

  • Wordsmith.
  • Remove unused variable.
  • Remove slightly more code.
This revision was automatically updated to reflect the committed changes.