Page MenuHomePhabricator

Let "<select />" EditEngine fields canonicalize saved defaults
ClosedPublic

Authored by epriestley on Jun 20 2017, 10:27 PM.
Tags
None
Referenced Files
F15395370: D18142.diff
Sun, Mar 16, 6:19 AM
F15395261: D18142.id43651.diff
Sun, Mar 16, 4:25 AM
F15385135: D18142.id43651.diff
Fri, Mar 14, 9:48 PM
Unknown Object (File)
Feb 16 2025, 4:28 PM
Unknown Object (File)
Feb 3 2025, 7:00 PM
Unknown Object (File)
Feb 2 2025, 11:16 AM
Unknown Object (File)
Jan 25 2025, 1:21 AM
Unknown Object (File)
Jan 22 2025, 11:29 PM
Subscribers
None

Details

Summary

Ref T12124. After D18134 we accept either "25" or "low" via HTTP parameters and when the field renders as a control, but if the form has a default value for the field but locks or hides it we don't actually run through that logic.

Canonicalize both when rendering the control and when using a raw saved default value.

Test Plan
  • Created a form with "Priority: Low".
  • Hid the "Priority" field.
  • Before patch: Tried to create a task, was rebuffed with a (now verbose and helpful, after D18135) error.
  • Applied patch: things worked.

Diff Detail

Repository
rP Phabricator
Branch
task2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17542
Build 23537: Run Core Tests
Build 23536: arc lint + arc unit