Page MenuHomePhabricator

Let "<select />" EditEngine fields canonicalize saved defaults
ClosedPublic

Authored by epriestley on Jun 20 2017, 10:27 PM.
Tags
None
Referenced Files
F17868696: D18142.id43651.diff
Mon, Jul 28, 8:42 AM
F17802812: D18142.id.diff
Fri, Jul 25, 9:31 AM
F17799492: D18142.diff
Fri, Jul 25, 5:06 AM
F17754876: D18142.diff
Tue, Jul 22, 11:31 AM
Unknown Object (File)
Jun 18 2025, 12:31 AM
Unknown Object (File)
May 9 2025, 8:17 AM
Unknown Object (File)
May 7 2025, 4:44 PM
Unknown Object (File)
May 7 2025, 3:14 AM
Subscribers
None

Details

Summary

Ref T12124. After D18134 we accept either "25" or "low" via HTTP parameters and when the field renders as a control, but if the form has a default value for the field but locks or hides it we don't actually run through that logic.

Canonicalize both when rendering the control and when using a raw saved default value.

Test Plan
  • Created a form with "Priority: Low".
  • Hid the "Priority" field.
  • Before patch: Tried to create a task, was rebuffed with a (now verbose and helpful, after D18135) error.
  • Applied patch: things worked.

Diff Detail

Repository
rP Phabricator
Branch
task2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17542
Build 23537: Run Core Tests
Build 23536: arc lint + arc unit