Improve validation errors for changing task priorities
ClosedPublic
Actions

Authored by epriestley on Jun 19 2017, 7:40 PM.

Details

Reviewers

amckinley
chad

Maniphest Tasks

T12124: Counterintuitive priority setting via maniphest.edit conduit call

Commits

rPcd19ddf111dc: Improve validation errors for changing task priorities

Summary

Ref T12124. Currently, Conduit provides a fairly rough error message if you provide an invalid priority.

Instead, provide a more tailored message. Also, block !!unknown!! except from web edits.

Test Plan

Before:

Screen Shot 2017-06-19 at 12.33.57 PM.png (1×1 px, 186 KB)

After:

Screen Shot 2017-06-19 at 12.36.52 PM.png (1×1 px, 192 KB)

Also, changed a priority to 999 in the database, edited it with the normal web UI form, it let me make the edit without being forced to adjust the priority.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 19 2017, 7:40 PM

Harbormaster completed remote builds in B17526: Diff 43634.Jun 19 2017, 7:41 PM

amckinley accepted this revision.Jun 19 2017, 7:44 PM

This revision is now accepted and ready to land.Jun 19 2017, 7:44 PM

Closed by commit rPcd19ddf111dc: Improve validation errors for changing task priorities (authored by epriestley, committed by epriestley). · Explain WhyJun 19 2017, 9:05 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18142: Let "<select />" EditEngine fields canonicalize saved defaults.Jun 20 2017, 10:27 PM

epriestley mentioned this in rP149e6aaa2170: Let "<select />" EditEngine fields canonicalize saved defaults.Jun 21 2017, 12:42 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

xaction/

ManiphestTaskPriorityTransaction.php

46 lines

Diff 43638

View Options

src/applications/maniphest/xaction/ManiphestTaskPriorityTransaction.php

Improve validation errors for changing task prioritiesClosedPublicActions