Page MenuHomePhabricator

Fix an issue where Phriction moves to new locations would fail with a "content required" error
ClosedPublic

Authored by epriestley on Jun 2 2017, 11:14 PM.
Tags
None
Referenced Files
F13214952: D18069.diff
Fri, May 17, 1:59 PM
F13209623: D18069.id43460.diff
Fri, May 17, 1:12 AM
F13199265: D18069.diff
Mon, May 13, 1:22 PM
F13195147: D18069.diff
Sun, May 12, 10:10 PM
F13177932: D18069.diff
Wed, May 8, 8:03 PM
Unknown Object (File)
Thu, May 2, 3:20 PM
Unknown Object (File)
Thu, Apr 25, 1:00 AM
Unknown Object (File)
Apr 17 2024, 7:34 PM
Subscribers
None

Details

Summary

Ref T12793. I'd like to understand exactly when we broke this, but this seems to be a minimal fix that shouldn't do anything surprising.

When you move document /a/ to /a/b/ and that path doesn't exist yet, the Content transaction currently fails because there's "no content". The content gets added later by the "move" transaction but this is implicit.

To make this work, just ignore the "missing field" error. This is a little roundabout but unlikely to break anything in weird ways.

Test Plan
  • Moved document /a/b/ to /a/b/c/.
  • Before patch: error about missing content.
  • After patch: move worked properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable