Page MenuHomePhabricator

Fix an issue where Phriction moves to new locations would fail with a "content required" error
ClosedPublic

Authored by epriestley on Jun 2 2017, 11:14 PM.
Tags
None
Referenced Files
F13136718: D18069.diff
Thu, May 2, 3:20 PM
Unknown Object (File)
Thu, Apr 25, 1:00 AM
Unknown Object (File)
Wed, Apr 17, 7:34 PM
Unknown Object (File)
Thu, Apr 11, 6:56 AM
Unknown Object (File)
Sun, Apr 7, 3:12 PM
Unknown Object (File)
Sun, Apr 7, 2:07 PM
Unknown Object (File)
Sun, Apr 7, 4:44 AM
Unknown Object (File)
Sun, Apr 7, 4:16 AM
Subscribers
None

Details

Summary

Ref T12793. I'd like to understand exactly when we broke this, but this seems to be a minimal fix that shouldn't do anything surprising.

When you move document /a/ to /a/b/ and that path doesn't exist yet, the Content transaction currently fails because there's "no content". The content gets added later by the "move" transaction but this is implicit.

To make this work, just ignore the "missing field" error. This is a little roundabout but unlikely to break anything in weird ways.

Test Plan
  • Moved document /a/b/ to /a/b/c/.
  • Before patch: error about missing content.
  • After patch: move worked properly.

Diff Detail

Repository
rP Phabricator
Branch
move1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17374
Build 23290: Run Core Tests
Build 23289: arc lint + arc unit