Page MenuHomePhabricator
Differential D17966

Make Project slug/hashtag transactions render a little more nicely
ClosedPublic
Actions

Authored by epriestley on May 19 2017, 8:49 PM.
Tags
None
Referenced Files
F13265155: D17966.diff
Tue, May 28, 1:37 AM
F13248655: D17966.diff
Fri, May 24, 3:47 AM
F13228234: D17966.id.diff
Mon, May 20, 8:07 AM
F13173919: D17966.diff
Tue, May 7, 9:28 PM
Unknown Object (File)
Sat, May 4, 7:07 AM
Unknown Object (File)
Tue, Apr 30, 2:20 PM
Unknown Object (File)
Tue, Apr 30, 11:01 AM
Unknown Object (File)
Tue, Apr 30, 9:20 AM
View All Files
Subscribers
None

Details

Reviewers
chad
amckinley
Maniphest Tasks
T12732: 2017 Week 20 Transactions Errata
Commits
rP10b387923208: Make Project slug/hashtag transactions render a little more nicely
Summary

Ref T12732. Use renderValue() to build renderValueList() so we get nice fancy text for these.

Test Plan

Screen Shot 2017-05-19 at 1.47.31 PM.png (149×476 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Branch
tweak1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17123
Build 22910: Run Core Tests
Build 22909: arc lint + arc unit

Event Timeline

epriestley created this revision.May 19 2017, 8:49 PM
Harbormaster completed remote builds in B17121: Diff 43210.May 19 2017, 8:50 PM
amckinley accepted this revision.May 19 2017, 8:50 PM

Slugworth approves.

Slugworth.jpg (395×575 px, 40 KB)

This revision is now accepted and ready to land.May 19 2017, 8:50 PM
chad edited edge metadata.May 19 2017, 8:52 PM

Can we put an actual # there too?

amckinley added a comment.May 19 2017, 8:53 PM
In D17966#217662, @chad wrote:

Can we put an actual # there too?

Maybe make renderValueList() take optional separator and prefix arguments?

epriestley added a comment.May 19 2017, 8:55 PM

I vaguely imagine that the comma separator will eventually be a translation issue that gets farmed out to the translation engine, so the Historically Accurate Mongol localization can use 🐺 as a list separator.

epriestley updated this revision to Diff 43212.May 19 2017, 8:58 PM

#yolo #hashtag

Screen Shot 2017-05-19 at 1.57.01 PM.png (70×538 px, 10 KB)

Harbormaster completed remote builds in B17123: Diff 43212.May 19 2017, 8:58 PM
Harbormaster completed remote builds in B17123: Diff 43212.
Closed by commit rP10b387923208: Make Project slug/hashtag transactions render a little more nicely (authored by epriestley, committed by epriestley). · Explain WhyMay 19 2017, 8:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
xaction/
30 lines
transactions/
storage/
13 lines

Diff 43212

View Options

src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility