Paths

Table of Contentst

Make Project slug/hashtag transactions render a little more nicely
ClosedPublic
Actions

Authored by epriestley on May 19 2017, 8:49 PM.

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12732: 2017 Week 20 Transactions Errata

Commits

rP10b387923208: Make Project slug/hashtag transactions render a little more nicely

Summary

Ref T12732. Use renderValue() to build renderValueList() so we get nice fancy text for these.

Test Plan

Screen Shot 2017-05-19 at 1.47.31 PM.png (149×476 px, 18 KB)

Diff Detail

Repository

rP Phabricator

Branch

tweak1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17123
Build 22910: Run Core Tests
Build 22909: arc lint + arc unit

Event Timeline

epriestley created this revision.May 19 2017, 8:49 PM

Harbormaster completed remote builds in B17121: Diff 43210.May 19 2017, 8:50 PM

Slugworth approves.

This revision is now accepted and ready to land.May 19 2017, 8:50 PM

Can we put an actual # there too?

In D17966#217662, @chad wrote:

Can we put an actual # there too?

Maybe make renderValueList() take optional separator and prefix arguments?

I vaguely imagine that the comma separator will eventually be a translation issue that gets farmed out to the translation engine, so the Historically Accurate Mongol localization can use 🐺 as a list separator.

#yolo #hashtag

Harbormaster completed remote builds in B17123: Diff 43212.May 19 2017, 8:58 PM

Harbormaster completed remote builds in B17123: Diff 43212.

Closed by commit rP10b387923208: Make Project slug/hashtag transactions render a little more nicely (authored by epriestley, committed by epriestley). · Explain WhyMay 19 2017, 8:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

xaction/

PhabricatorProjectSlugsTransaction.php

30 lines

transactions/

storage/

PhabricatorModularTransactionType.php

13 lines

Diff 43212

View Options

src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php