Improve mobile/device behaviors for inline comments
ClosedPublic
Actions

Authored by epriestley on May 17 2017, 2:40 PM.

Tags

None

Referenced Files

	F15468972: D17928.diff
	Fri, Apr 4, 8:09 AM

	F15426244: D17928.diff
	Sun, Mar 23, 7:51 AM

	F15413433: D17928.diff
	Wed, Mar 19, 6:40 PM

	F15411223: D17928.diff
	Wed, Mar 19, 8:55 AM

	F15411019: D17928.diff
	Wed, Mar 19, 8:46 AM

	F15410948: D17928.diff
	Wed, Mar 19, 8:43 AM

	F15392266: D17928.id.diff
	Sat, Mar 15, 2:12 PM

	F15336734: D17928.diff
	Sun, Mar 9, 12:24 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T1026: Request: ability to select line range for comment via touchscreen
T12616: Modernize display code for inline comments

Commits

rP343f7cac72bb: Improve mobile/device behaviors for inline comments

Summary

Fixes T1026. Ref T12616. Allows drag-to-select on devices to add inlines on a range of lines, using dark magic that I copy/pasted from StackOverflow.

Test Plan

Left a comment on a range of lines on iPhone simulator.

Diff Detail

Repository

rP Phabricator

Branch

inline19

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17047
Build 22797: Run Core Tests
Build 22796: arc lint + arc unit

Event Timeline

epriestley created this revision.May 17 2017, 2:40 PM

Harbormaster completed remote builds in B17047: Diff 43122.May 17 2017, 2:41 PM

chad accepted this revision.May 17 2017, 3:06 PM

This revision is now accepted and ready to land.May 17 2017, 3:06 PM

Closed by commit rP343f7cac72bb: Improve mobile/device behaviors for inline comments (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2017, 3:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

52 lines

Diff 43122

View Options

resources/celerity/map.php