Page MenuHomePhabricator

Improve mobile/device behaviors for inline comments
ClosedPublic

Authored by epriestley on May 17 2017, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 26, 10:16 AM
Unknown Object (File)
Sat, Sep 17, 11:18 AM
Unknown Object (File)
Aug 5 2022, 12:07 AM
Unknown Object (File)
Aug 3 2022, 11:00 PM
Unknown Object (File)
Jul 28 2022, 9:26 PM
Unknown Object (File)
Jul 14 2022, 9:50 AM
Unknown Object (File)
Jul 4 2022, 4:32 AM
Unknown Object (File)
Jul 2 2022, 10:57 PM
Subscribers
None

Details

Summary

Fixes T1026. Ref T12616. Allows drag-to-select on devices to add inlines on a range of lines, using dark magic that I copy/pasted from StackOverflow.

Test Plan

Left a comment on a range of lines on iPhone simulator.

Diff Detail

Repository
rP Phabricator
Branch
inline19
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17047
Build 22797: Run Core Tests
Build 22796: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 17 2017, 3:06 PM
This revision was automatically updated to reflect the committed changes.