Hide the Differential keyboard focus reticle after Quicksand navigation
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 1:47 PM.

Details

Reviewers

Maniphest Tasks

T8047: Differential inline reticle can persist across Quicksand navigations
T12634: Keyboard focus reticle is generally oblivious to the world around it

Commits

rP5d7202526f3d: Hide the Differential keyboard focus reticle after Quicksand navigation

Summary

Ref T8047. Ref T12634. When we sleep, hide the reticle. Restore it when we wake.

Test Plan

With Quicksand enabled..
Used "j" to select a change in a revision.
Navigated away by clicking a link.
WOW! Reticle vanished properly!
Used "back" to return.
Reticle returned properly.

Diff Detail

Repository

rP Phabricator

Branch

focus2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16987
Build 22707: Run Core Tests
Build 22706: arc lint + arc unit

Event Timeline

epriestley created this revision.May 16 2017, 1:47 PM

Harbormaster failed remote builds in B16986: Diff 43058!May 16 2017, 1:48 PM

Rebuild Celerity map properly.

Harbormaster completed remote builds in B16987: Diff 43059.May 16 2017, 1:50 PM

chad accepted this revision.May 16 2017, 2:18 PM

This revision is now accepted and ready to land.May 16 2017, 2:18 PM

Closed by commit rP5d7202526f3d: Hide the Differential keyboard focus reticle after Quicksand navigation (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

6 lines

Diff 43059

View Options

resources/celerity/map.php