Page MenuHomePhabricator

Hide the Differential keyboard focus reticle after Quicksand navigation
ClosedPublic

Authored by epriestley on May 16 2017, 1:47 PM.
Tags
None
Referenced Files
F11013660: D17900.diff
Mon, Aug 8, 10:16 PM
Unknown Object (File)
Fri, Aug 5, 4:58 AM
Unknown Object (File)
Fri, Jul 29, 11:00 AM
Unknown Object (File)
Mon, Jul 25, 3:20 AM
Unknown Object (File)
Sat, Jul 16, 3:53 AM
Unknown Object (File)
Thu, Jul 14, 9:48 AM
Unknown Object (File)
Sun, Jul 10, 12:40 PM
Unknown Object (File)
Jul 5 2022, 7:47 AM
Subscribers
None

Details

Summary

Ref T8047. Ref T12634. When we sleep, hide the reticle. Restore it when we wake.

Test Plan
  • With Quicksand enabled..
  • Used "j" to select a change in a revision.
  • Navigated away by clicking a link.
  • WOW! Reticle vanished properly!
  • Used "back" to return.
  • Reticle returned properly.

Diff Detail

Repository
rP Phabricator
Branch
focus2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16986
Build 22705: Run Core Tests
Build 22704: arc lint + arc unit

Unit TestsFailed

TimeTest
267 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
4 assertions passed.
1 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
1 assertion passed.
View Full Test Results (1 Failed · 337 Passed)