Page MenuHomePhabricator

Hide the Differential keyboard focus reticle after Quicksand navigation
ClosedPublic

Authored by epriestley on May 16 2017, 1:47 PM.
Tags
None
Referenced Files
F13175995: D17900.id43059.diff
Wed, May 8, 9:30 AM
Unknown Object (File)
Sat, May 4, 1:13 AM
Unknown Object (File)
Thu, May 2, 10:22 PM
Unknown Object (File)
Wed, May 1, 11:41 AM
Unknown Object (File)
Mon, Apr 29, 3:52 PM
Unknown Object (File)
Sat, Apr 27, 8:58 AM
Unknown Object (File)
Thu, Apr 25, 3:30 AM
Unknown Object (File)
Wed, Apr 24, 11:48 PM
Subscribers
None

Details

Summary

Ref T8047. Ref T12634. When we sleep, hide the reticle. Restore it when we wake.

Test Plan
  • With Quicksand enabled..
  • Used "j" to select a change in a revision.
  • Navigated away by clicking a link.
  • WOW! Reticle vanished properly!
  • Used "back" to return.
  • Reticle returned properly.

Diff Detail

Repository
rP Phabricator
Branch
focus2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16986
Build 22705: Run Core Tests
Build 22704: arc lint + arc unit

Unit TestsFailed

TimeTest
267 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
4 assertions passed.
1 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
1 assertion passed.
View Full Test Results (1 Failed · 337 Passed)