Page MenuHomePhabricator
Differential D17878

Make a handful of minor Slowvote behaviors more consistent with other applications
ClosedPublic
Actions

Authored by epriestley on May 14 2017, 8:51 PM.
Tags
None
Referenced Files
F15436336: D17878.id43000.diff
Tue, Mar 25, 1:31 PM
F15434994: D17878.id.diff
Tue, Mar 25, 6:18 AM
F15430207: D17878.diff
Mon, Mar 24, 6:28 AM
F15429591: D17878.id43000.diff
Mon, Mar 24, 3:03 AM
Unknown Object (File)
Sat, Mar 1, 11:38 PM
Unknown Object (File)
Mon, Feb 24, 12:37 AM
Unknown Object (File)
Feb 21 2025, 3:22 PM
Unknown Object (File)
Feb 20 2025, 11:34 AM
View All Files
Subscribers
None

Details

Reviewers
chad
amckinley
Maniphest Tasks
T12685: Modular Transactions Migrations Errata
Commits
rPc7a642255997: Make a handful of minor Slowvote behaviors more consistent with other…
Summary

Ref T12685.

  • Better icon/color/label consistency.
  • Make "0" a valid response.
  • Fix a bug where creating a poll with Quicksand enabled led to bad times (form submitted back to the search screen).
Test Plan

Screen Shot 2017-05-14 at 1.51.04 PM.png (1×1 px, 154 KB)

Diff Detail

Repository
rP Phabricator
Branch
err4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16922
Build 22613: Run Core Tests
Build 22612: arc lint + arc unit

Event Timeline

epriestley created this revision.May 14 2017, 8:51 PM
Harbormaster completed remote builds in B16922: Diff 42998.May 14 2017, 8:52 PM
epriestley updated this revision to Diff 43000.May 14 2017, 8:54 PM
  • Bonus! Change creation string from "created this object" to "created this poll".
Harbormaster completed remote builds in B16923: Diff 43000.May 14 2017, 8:55 PM
chad accepted this revision.May 14 2017, 8:56 PM
This revision is now accepted and ready to land.May 14 2017, 8:56 PM
Closed by commit rPc7a642255997: Make a handful of minor Slowvote behaviors more consistent with other… (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2017, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42998

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
Phabricator · Built by Phacility